Skip to content

Benchmarking overhaul and pin Flake8 <6#220

Merged
stephenworsley merged 19 commits intoSciTools:mainfrom
trexfeathers:benchmarks_update
Nov 25, 2022
Merged

Benchmarking overhaul and pin Flake8 <6#220
stephenworsley merged 19 commits intoSciTools:mainfrom
trexfeathers:benchmarks_update

Conversation

@trexfeathers
Copy link
Copy Markdown
Contributor

@trexfeathers trexfeathers commented Nov 21, 2022

A detailed restructure of the benchmarking architecture in line with what has already been done on SciTools/iris. The original architecture included several experiments which we have since iterated and improved within Iris.

Closes #210.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 21, 2022 •
edited
Loading

Codecov Report

Merging #220 (6957388) into main (10cb843) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files          28       28           
  Lines        2829     2829           
=======================================
  Hits         2811     2811           
  Misses         18       18

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

stephenworsley
stephenworsley requested changes Nov 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Just one comment about the license header in one file.

Comment thread benchmarks/asv_delegated_conda.py Outdated
@trexfeathers
Copy link
Copy Markdown
Contributor Author

trexfeathers commented Nov 24, 2022

Flake8 failure seems possibly related to PyCQA/flake8#1739, but I have not yet worked out what in our config is causing the problem.

@trexfeathers
Copy link
Copy Markdown
Contributor Author

trexfeathers commented Nov 24, 2022

See also PyCQA/flake8#1758

@trexfeathers
Copy link
Copy Markdown
Contributor Author

trexfeathers commented Nov 24, 2022 •
edited
Loading

Flake8 failure seems possibly related to PyCQA/flake8#1739, but I have not yet worked out what in our config is causing the problem.

Happens even without any config at all in .flake8, so I reckon somethings wrong. I'll pin it

22a6f63

@trexfeathers
Copy link
Copy Markdown
Contributor Author

trexfeathers commented Nov 25, 2022 •
edited
Loading

Flake8 failure seems possibly related to PyCQA/flake8#1739, but I have not yet worked out what in our config is causing the problem.

Should be fixed once PyCQA/flake8-import-order#190 is in a release.

stephenworsley
stephenworsley approved these changes Nov 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I guess we can ignore the greetings failure for the time being as that seems to be a seperable issue.

@trexfeathers trexfeathers changed the title Benchmarking overhaul Benchmarking overhaul and pin Flake8 <6 Nov 25, 2022
@stephenworsley stephenworsley merged commit 88d2c98 into SciTools:main Nov 25, 2022
@trexfeathers trexfeathers mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenworsley stephenworsley stephenworsley approved these changes

Assignees

@stephenworsley stephenworsley

Labels

Experience: Medium Type: Performance Type: Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Benchmarks failing to run.

2 participants

@trexfeathers @stephenworsley